Re: VACUUM messages without newlines

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Thom Brown <thombrown(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: VACUUM messages without newlines
Date: 2010-06-01 15:28:41
Message-ID: 1275405940-sup-4136@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Thom Brown's message of mar jun 01 11:16:33 -0400 2010:
> This has annoyed me for some time, but it appears that in the VACUUM
> log, the line which says...
>
> INFO: analyzing "%s.%s"
>
> ...( and appears in pgsql/src/backend/commands/analyze.c lines 282 and
> 287 ) doesn't terminate with a newline, meaning the next message
> appears immediately after it.

The message pieces are sent separately. They are only crammed in a
single line if the interface is using the old mechanism to extract error
message info; anything built after cca. 2002 should be reading fields
separately, and printing them in separate lines.

> The same goes for...
>
> CPU %d.%02ds/%d.%02du sec elapsed %d.%02d sec

Now you can argue that this line is too long, but that's a different
problem than the one above.

> "%s": scanned %d of %u pages, containing %.0f live rows and %.0f dead
> rows; %d rows in sample, %.0f estimated total rows

This too.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2010-06-01 15:30:54 Re: dividing money by money
Previous Message Thom Brown 2010-06-01 15:16:33 VACUUM messages without newlines