| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Keepalive for max_standby_delay |
| Date: | 2010-05-17 07:07:04 |
| Message-ID: | 1274080024.28911.76.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2010-05-17 at 11:51 +0900, Fujii Masao wrote:
> Is it OK that this keepalive message cannot be used by HS in file-based
> log-shipping? Even in SR, the startup process cannot use the keepalive
> until walreceiver has been started up.
Yes, I see those things.
We already have archive_timeout to handle the keepalive case in
file-based.
When starting up the delay is high anyway, so doesn't really matter
about accuracy - though we do use latestXLogTime in that cases.
> WalSndKeepAlive() always calls initStringInfo(), which seems to cause
> memory-leak.
Thanks.
--
Simon Riggs www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2010-05-17 07:13:59 | Re: Stefan's bug (was: max_standby_delay considered harmful) |
| Previous Message | Fujii Masao | 2010-05-17 02:51:13 | Re: Keepalive for max_standby_delay |