Re: Ignoring some binaries generated in src/test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Ignoring some binaries generated in src/test
Date: 2015-04-24 21:14:50
Message-ID: 12609.1429910090@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> The current logic in src/test/Makefile, particularly the way that
>> the modules subdirectory is handled, seems pretty ugly/convoluted
>> anyway. I wonder why it was done that way rather than just ensuring
>> that modules/ doesn't do anything for "make install"?

> Because we do want to have the Makefile in src/test/modules to install
> the modules if "make install" is invoked there. That way, you can run
> "make -C src/test/modules install installcheck", and it works.

OK. I still wonder if there isn't a better way to get that effect, but
I left it alone for now. I committed Michael's new .gitignore files and
fixed the Makefiles so that "make clean" and friends clean up properly.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2015-04-24 21:36:12 Re: Feedback on getting rid of VACUUM FULL
Previous Message Alvaro Herrera 2015-04-24 20:34:01 Re: Feedback on getting rid of VACUUM FULL