Re: Hot standby and removing VACUUM FULL

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Hot standby and removing VACUUM FULL
Date: 2009-12-04 12:04:17
Message-ID: 1259928257.13774.38166.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 2009-12-04 at 13:31 +0200, Heikki Linnakangas wrote:

> b) seems much simpler to me.

OK. Least ugly wins, but she ain't pretty.

> > 2. (In HS recovery) When we see first commit record for the VF xid we
> > commit the transaction in clog, yet maintain locks and KnownAssigned
> > xids
> >
> > 3. (In HS recovery) When we see second commit record for the VF xid we
> > skip clog updates but then perform remaining parts of commit.
>
> I's harmless to set a clog entry as committed twice, so you can treat
> the 2nd commit record the same as a regular commit record.

Yeh, OK, it is harmless and makes code cleaner.

--
Simon Riggs www.2ndQuadrant.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-12-04 12:12:54 Re: Block-level CRC checks
Previous Message Greg Stark 2009-12-04 12:02:47 Re: Block-level CRC checks