Re: Patch: show relation and tuple infos of a lock to acquire

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Christian Kruse <christian(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: show relation and tuple infos of a lock to acquire
Date: 2014-03-18 00:21:18
Message-ID: 12552.1395102078@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> 1. MyProcPort contains the database name; no need for the
> get_database_name() call in there.

Wait. A. Minute. This patch wants to print the current database name in
the message? What on earth for? What other error messages do you see
doing that?

It should print a table name and a TID. Not more, not less. If there's
any doubt as to whether you have both of those pieces of information,
the patch still needs work.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-03-18 00:24:26 Re: Patch: show relation and tuple infos of a lock to acquire
Previous Message Alvaro Herrera 2014-03-18 00:10:23 Re: Patch: show relation and tuple infos of a lock to acquire