Re: SIGUSR1 pingpong between master na autovacum launcher causes crash

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SIGUSR1 pingpong between master na autovacum launcher causes crash
Date: 2009-08-24 12:36:27
Message-ID: 1251117387.3252.24.camel@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Zdenek Kotala píše v po 24. 08. 2009 v 13:47 +0200:

> I tested Alvaro's patch and it works, because it does not lead to stack
> consumption, but it shows another bug in StartAutovacuumWorker() code.
> When fork fails bn structure is freed but
> ReleasePostmasterChildSlot() should be called as well. See error:
>
> 2009-08-24 11:50:20.360 CEST 3468 FATAL: no free slots in PMChildFlags array
>
> and comment in source code:
>
> /* Out of slots ... should never happen, else postmaster.c messed up */
>

Just a confirmation that Alvaro's patch+ReleasePostmasterChildSlot() fix
solves the problem and PostgreSQL survives well during a memory
shortages.

Zdenek

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2009-08-24 12:39:02 hba load error and silent mode
Previous Message Zdenek Kotala 2009-08-24 11:47:27 Re: SIGUSR1 pingpong between master na autovacum launcher causes crash