| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader |
| Date: | 2012-10-30 15:30:43 |
| Message-ID: | 12219.1351611043@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> And yeah, I was thinking in one sum for the header and another one for
> the data.
I don't think it's worth the space.
> If we're using CRC to detect end of WAL, what sense does it
> make to have to read the whole record if we can detect the end by just
> looking at the header?
Er, what? The typical case where CRC shows us it's end of WAL is that
the overall CRC doesn't match, ie, torn record. Record header
corruption as such is just about nonexistent AFAIK.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2012-10-30 15:32:31 | Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader |
| Previous Message | Alvaro Herrera | 2012-10-30 15:24:21 | Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader |