Re: Do we need a ShmList implementation?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: "Simon Riggs" <simon(at)2ndQuadrant(dot)com>, "Heikki Linnakangas" <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Do we need a ShmList implementation?
Date: 2010-09-20 16:35:24
Message-ID: 12208.1285000524@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> wrote:
>> My understanding is that we used to have that and it was removed
>> for the reasons Heikki states. There are still vestigial bits
>> still in code.

There's nothing vestigial about SHM_QUEUE --- it's used by the lock
manager. But it's intended to link together structs whose existence
is managed by somebody else.

>> Not exactly impressed with the SHM_QUEUE stuff though, so I
>> appreciate the sentiment that Kevin expresses.

> So, if I just allocated a fixed memory space to provide an API
> similar to my previous post, does that sound reasonable to you?

I'm not excited about inventing an API with just one use-case; it's
unlikely that you actually end up with anything generally useful.
(SHM_QUEUE seems like a case in point...) Especially when there are so
many other constraints on what shared memory is usable for. You might
as well just do this internally to the SERIALIZABLEXACT management code.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-09-20 16:38:33 Re: compile/install of git
Previous Message Heikki Linnakangas 2010-09-20 16:28:55 Re: Do we need a ShmList implementation?