Re: TAP test breakage on MacOS X

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TAP test breakage on MacOS X
Date: 2014-10-30 22:32:28
Message-ID: 11656.1414708348@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> writes:
> On 10/30/14, 4:55 PM, Tom Lane wrote:
>> I think it should be. You should not have to have either prove or
>> IPC::Run (or, IIRC, even Perl) in order to do make check-world.

> Could configure detect if we have IPC::Run? ISTM it'd be nice to make this automatic instead of requiring it to be specifically enabled.

The general philosophy we have about features enabled by configure is
exactly opposite to that: we do not for example look for Perl and then
build or not build plperl dependent on that. If you want plperl, you
tell us so, and then we either build it or fail because we can't.

You could argue that test coverage is different from features of the
completed package, but I don't really buy that.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2014-10-30 23:06:02 Re: proposal: CREATE DATABASE vs. (partial) CHECKPOINT
Previous Message David G Johnston 2014-10-30 22:19:03 Re: SET TABLESPACE ... NOWAIT