Re: Corner case in xlog stuff: what happens exactly at a

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Corner case in xlog stuff: what happens exactly at a
Date: 2006-08-07 15:36:11
Message-ID: 1154964971.2570.85.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 2006-08-05 at 23:59 -0400, Tom Lane wrote:
> I wrote:
> > Rather than expecting user-level scripts to get this corner case
> > right, I suggest that we ought to modify pg_stop_backup and friends
> > so that what they return is the last used byte address of WAL, not
> > the first unused byte address as now. Then, blindly extracting
> > the filename will give the right answer about which file to archive,
> > even in the boundary case.
>
> After further thought I desisted from that plan: changing the result
> convention of existing functions like pg_stop_backup() will break any
> existing archiving scripts that do get it right. Instead, we can put
> the boundary-case logic into the new functions that extract a filename
> from the WAL location string that the action functions return.

This is done right? Ping me back if there's anything more to add.

--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-08-07 15:37:58 Re: Simplifying "standby mode"
Previous Message Simon Riggs 2006-08-07 15:31:19 Re: Simplifying "standby mode"