Re: Inconsistency in extended-query-protocol logging

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Inconsistency in extended-query-protocol logging
Date: 2006-09-13 14:30:27
Message-ID: 11389.1158157827@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com> writes:
> I attached a patch to improve the consistency. It adds statement: for
> every case.

Isn't that just bloating the log? And weren't you the one complaining
about log volumes to begin with?

The reason it is why it is is that Bruce wanted the wording to reflect
why you are getting the log message: anything starting "statement:"
is being logged because of log_statement, anything starting "duration:"
is being logged because of one of the log_duration variables. Your
proposed patch blurs that distinction and doesn't buy anything much
that I can see.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-09-13 14:47:09 Re: -HEAD planner issue wrt hash_joins on dbt3 ?
Previous Message Andrew Dunstan 2006-09-13 14:00:22 Re: Getting a move on for 8.2 beta