| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Peter Geoghegan <peter(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH 04/16] Add embedded list interface (header only) |
| Date: | 2012-06-22 14:41:20 |
| Message-ID: | 11221.1340376080@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> Oh, I and Peter weren't talking about the pg_list.h stuff, it was about my
> 'embedded list' implementation which started this subthread. The
> pg_list.h/list.c stuff isn't problematic as far as I have seen in profiles;
> its checks are pretty simple so I do not find that surprising. We might want
> to disable it by default anyway.
> In my code the list checking stuff iterates over the complete list after
> modifications and checks that all prev/next pointers are correct so its linear
> in itself...
Well, so does list.c, so I'd expect the performance risks to be similar.
Possibly you're testing on longer lists than are typical in the backend.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2012-06-22 14:45:10 | Re: [PATCH 01/16] Overhaul walsender wakeup handling |
| Previous Message | Robert Haas | 2012-06-22 14:34:33 | Re: [PATCH 01/16] Overhaul walsender wakeup handling |