| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, ntufar(at)gmail(dot)com, devrim(at)kivi(dot)com(dot)tr, mha(at)sollentuna(dot)net, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] snprintf() argument reordering not working |
| Date: | 2005-12-05 18:18:56 |
| Message-ID: | 1109.1133806736@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> The bad news: if we aren't compiling with NLS enabled, having those
> entries in exports.txt makes the libpq build blow up. So either we need
> to use pg_*printf unconditionally on Windows, or we need a little
> Makefile + sed magic to strip those entries out of exports.txt when it
> is used, if we're not doing NLS, or something of that kind.
I think it's a bad idea for exports.txt not to be the same in all
builds. So yeah, if we export these names at all then it has to be
unconditional.
What about Plan B? Per Bruce's comment, it should really only be ecpg
that needs an extra copy of snprintf.o, and it's not like ecpg doesn't
already pull in various port/ files for itself.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-12-05 18:19:57 | Re: [PATCHES] snprintf() argument reordering not working |
| Previous Message | Jan Wieck | 2005-12-05 18:09:48 | Re: SERIAL type feature request |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-12-05 18:19:57 | Re: [PATCHES] snprintf() argument reordering not working |
| Previous Message | Andrew Dunstan | 2005-12-05 17:53:49 | Re: [PATCHES] snprintf() argument reordering not working |