Re: [bug fix] Suppress "autovacuum: found orphan temp table" message

From: "MauMau" <maumau307(at)gmail(dot)com>
To: "Andres Freund" <andres(at)2ndquadrant(dot)com>, "Robert Haas" <robertmhaas(at)gmail(dot)com>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] Suppress "autovacuum: found orphan temp table" message
Date: 2014-07-22 15:13:26
Message-ID: 1105974C40FF4A93911D4B310EEF8DD8@maumau
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello, Robert-san, Andres-san, Tom-san,

From: "Andres Freund" <andres(at)2ndquadrant(dot)com>
> a) There very well could be a backend reconnecting to that
> backendId. Then we potentially might try to remove the temp schema
> from two backends - I'm not sure that's always going to end up going
> well. There's already a race window, but it's pretty darn unlikely to
> hit it right now because the wraparound case pretty much implies that
> nothing has used that backendid slot for a while.
> I guess we could do something like:
>
> LockDatabaseObject(tempschema);
> if (SearchSysCacheExists1)
> /* bailout */
> performDeletion(...);
>
> b) I think at the very least we also need to call RemovePgTempFiles()
> during crash restart.

Thank you for showing the direction. I'll investigate the code. But that
will be tomorrow as it's already past midnight.

Could it be included in 9.2.9 if I could submit the patch tomorrow? (I'm not
confident I can finish it...) I'd really appreciate it if you could create
the fix, if tomorrow will be late.

Regards
MauMau

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-07-22 15:41:20 Re: Some bogus results from prairiedog
Previous Message Andres Freund 2014-07-22 15:11:53 Re: [bug fix] Suppress "autovacuum: found orphan temp table" message