Re: pgsql: Check dup2() results in syslogger

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Check dup2() results in syslogger
Date: 2014-01-27 17:27:49
Message-ID: 10971.1390843669@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> In short, this patch was ill considered. Please revert. If we need
>> to silence a Coverity complaint, perhaps a cast-to-void will do?

> Sure, I'll adjust it accordingly.

Feel free to improve the comment if you think it could be clearer.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-01-27 20:38:03 pgsql: Keep pg_stat_statements' query texts in a file, not in shared me
Previous Message Stephen Frost 2014-01-27 17:17:05 Re: pgsql: Check dup2() results in syslogger