Re: CVS HEAD is broken by flex

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: CVS HEAD is broken by flex
Date: 2007-09-12 04:04:31
Message-ID: 10971.1189569871@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> The suspect is flex (or yy template file). It defines "__unused" to
> be empty, but netdb.h uses "__unused" as a variable.

Egad. Shouldn't there be villagers breaking down the flex hackers'
front door with torches and pitchforks in hand? Why is it our problem
to fix their stupidity?

> [src/bin/psql/psqlscan.c]
> 9 #if defined(__FreeBSD__)
> 10 #include <sys/cdefs.h>
> 11 #else
> -> 12 #define __unused
> 13 #endif

Surely lines 11 and 12 should simply go away.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-09-12 04:08:57 Re: buildfarm failure after ICC configure change
Previous Message Tatsuo Ishii 2007-09-12 03:43:56 Re: invalidly encoded strings