Re: Skip hole in log_newpage

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Skip hole in log_newpage
Date: 2013-12-03 14:54:42
Message-ID: 10684.1386082482@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> The log_newpage function, used to WAL-log a full copy of a page, is
> missing the trick we normally use for full-page images to leave out the
> unused space on the block. That's pretty trivial to implement, so we should.

> Anyone see a problem with this?

+1. Don't forget to bump the WAL version identifier.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-12-03 14:54:52 Re: Proposed feature: Selective Foreign Keys
Previous Message Tom Lane 2013-12-03 14:48:23 Re: pgsql: Fix a couple of bugs in MultiXactId freezing