Re: fix log_min_duration_statement logic error

From: Rod Taylor <rbt(at)rbt(dot)ca>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix log_min_duration_statement logic error
Date: 2003-10-05 19:05:30
Message-ID: 1065380730.23288.190.camel@jester
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> > I have not heard from you why we should make it harder (split across two
> > lines), except for consistency with log_statement and log_duration
> > outputs.

I think this is a perfectly good argument. Don't make writing the tools
to parse the log more difficult than necessary.

Rather than making the log files look nice, lets add a module to PgAdmin
that can read it and display it in a user friendly manner (with
abilities like sorting queries by execution time!).

> Should we instead convert newlines to "\n" and output the query as a
> single line? Do we have lots of other multi-line outputs in the log
> files?

Please don't. Or if you do, don't data unless you intend to escape
special characters (in this case \) at the same time so we can convert
it back to the original state.

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-10-05 20:11:54 Re: fix log_min_duration_statement logic error
Previous Message Bruce Momjian 2003-10-05 19:00:15 Re: fix log_min_duration_statement logic error