From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
Cc: | heikki(dot)linnakangas(at)enterprisedb(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: regclass without error? |
Date: | 2011-01-04 16:01:02 |
Message-ID: | 10506.1294156862@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tatsuo Ishii <ishii(at)postgresql(dot)org> writes:
>> Why is any of this necessary? It sure looks like you are solving a
>> problem at the wrong level.
> Please read upthread.
You haven't made any argument why this shouldn't be solvable at the
client side, or at worst with a plpgsql DO block; either of which answer
would have the considerable merit of working against existing server
releases.
But in any case I see no reason to mess with the regclass code.
The C code you want is just
names = stringToQualifiedNameList(class_name);
result = RangeVarGetRelid(makeRangeVarFromNameList(names), true);
and there is no way that refactoring is going to yield a solution more
elegant than just duplicating those two lines --- especially since
regclassin has other cases for which zero is a non-error result.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2011-01-04 16:27:08 | Re: Re: new patch of MERGE (merge_204) & a question about duplicated ctid |
Previous Message | Tatsuo Ishii | 2011-01-04 15:48:25 | Re: regclass without error? |