rhaas(at)postgresql(dot)org (Robert Haas) writes:
> Add new escaping functions PQescapeLiteral and PQescapeIdentifier.
Minor gripe: this loop test is unsafe:
+ /* Scan the string for characters that must be escaped. */
+ for (s = str; *s != '\0' && (s - str) < len; ++s)
Should check len first, else you might be fetching a byte that isn't
there.
On a stylistic level, shouldn't as_ident be declared bool not int?
regards, tom lane