| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com> |
| Subject: | Re: tracking commit timestamps |
| Date: | 2014-11-07 23:36:55 |
| Message-ID: | 04A2F8C8-6428-4B4C-B07C-B00C218314CF@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
On Nov 4, 2014, at 4:20 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On 11/3/14 5:17 PM, Petr Jelinek wrote:
>>> Please don't name anything "committs". That looks like a misspelling of
>>> something.
>>>
>>> There is nothing wrong with
>>>
>>> pg_get_transaction_commit_timestamp()
>>>
>>> If you want to reduce the length, lose the "get".
>>
>> I am fine with that, I only wonder if your definition of "anything" only
>> concerns the SQL interfaces or also the internals.
>
> I'd be fine with commit_ts for internals, but not committs.
I agree that committs is poor. But I'd argue for spelling out commit_timestamp everywhere. It is more clear and easier to grep.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-11-07 23:45:39 | Re: Sequence Access Method WIP |
| Previous Message | Robert Haas | 2014-11-07 23:35:16 | Re: tracking commit timestamps |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2014-11-08 00:07:51 | Re: tracking commit timestamps |
| Previous Message | Robert Haas | 2014-11-07 23:35:16 | Re: tracking commit timestamps |