Re: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

On Monday, August 05, 2013 10:12 PM Josh Berkus wrote:
> All,
>
> To limit the argument here, let's please not argue about things which
> people already agree on. So:
>
> We seem to have consensus around:
>
> A) the inadvisability of storing GUCs in a system catalog.
>
> B) the utility of a conf.d in /etc/ which may have nothing to do with
> ALTER SYSTEM SET
>
> C) that any file for ALTER SYSTEM SET go in $PGDATA somewhere.
>
> What we are still arguing about:

Summarization of discussion, please add if I have missed or misunderstood any conclusive point:

> D) one-big-file vs. file-per-setting
Here I think there are no points against one-big-file and not much in favor of file-per-setting.
I believe there is enough support for one-big-file that there is no need to change it to file-per-setting.

> E) whether "unsafe" settings or "restart" settings should be allowed in
> ALTER SYSTEM SET.
a. Settings should continue to be in flat file. This will allow user to change settings incase anything goes wrong.
b. Few unsafe settings shouldn't be allowed to change, but there can be an option (new keyword FORCE) to change if user wants it.
Initial set of parameters suggested by Stephen Frost:
http://www.postgresql.org/message-id/20130802145442.GB2706@tamriel.snowman.net

> F) whether admins need the ability to disable ALTER SYSTEM SET.
a. UI into contrib module, people who don't want doesn't include it
b. Have an include file mechanism, so that user can comment the include in postgresql.conf and disable it.

Some new requirements
1. Show System command to separately show the values set by Alter System
2. append-to-this-GUC flag instead of overwriting the previous value.

With Regards,
Amit Kapila.