Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

From: Amit Kapila <amit(dot)kapila(at)huawei(dot)com>
To: "'Alvaro Herrera'" <alvherre(at)2ndquadrant(dot)com>
Cc: "'Greg Smith'" <greg(at)2ndQuadrant(dot)com>, "'Robert Haas'" <robertmhaas(at)gmail(dot)com>, "'Greg Stark'" <stark(at)mit(dot)edu>, "'Andres Freund'" <andres(at)2ndquadrant(dot)com>, "'Boszormenyi Zoltan'" <zb(at)cybertec(dot)at>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]
Date: 2013-03-23 01:50:52
Message-ID: 003901ce2768$da574ec0$8f05ec40$@kapila@huawei.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Friday, March 22, 2013 7:33 PM Alvaro Herrera wrote:
> Amit Kapila escribió:
> > On Friday, March 22, 2013 8:57 AM Alvaro Herrera wrote:
> > > Amit Kapila escribió:
>
> > > > I think adding new syntax change is little scary for me, not for
> > > > the matter of implementation but for building consensus on
> syntax.
> > >
> > > I cannot but agree on that point.
> >
> > Sorry, I don't get your point.
> > Do you mean to say that you don't agree with me and want new syntax
> as
> > proposed by you to be implemented?
>
> On the contrary, I was saying I agree with you on the difficulty on
> getting consensus on this.

Now based on final discussion, I will go-ahead and document the behavior
rather than using SIGHUP at end or giving NOTICE at end of command.
Let me know if anybody still feels otherwise.

Apart from this during Greg's testing, he found a performance problem with
running pg_reload_conf() along with my patch the reason for which actually
turns out to be a memory
growth. I have attempted to fix it in the patch ctx_growth_fix_v1.patch
which is currently attached in CF queue along with my Patch.
http://www.postgresql.org/message-id/004801ce216b$e37c3b30$aa74b190$@kapila@
huawei.com
I think that should be done irrespective of SET Persistent Patch.

> I don't know where I learned this phrase or even if it's in common
> usage. After a not-so-quick search I see it explained here:
> http://www.perfectyourenglish.com/usage/but.htm

You were right, I was not able to understand.

With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2013-03-23 02:37:16 Re: SIGHUP not received by custom bgworkers if postmaster is notified
Previous Message Ants Aasma 2013-03-23 00:46:20 Re: SDP query optimizer