Re: Don't allow relative path for copy from file

From: "Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "'PostgreSQL-development'" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Don't allow relative path for copy from file
Date: 2012-08-16 06:11:56
Message-ID: 001201cd7b76$09a973f0$1cfc5bd0$@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]

> "Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> > As described in the reference manual for COPY, we should to check file's
path
> > format not to allow relative path. Please find attached a patch.
>
> The argument for disallowing writing to a relative path is to make it
> harder to accidentally overwrite a database file. That argument does
> not apply to COPY IN, so I'm not convinced we should impose an
> additional restriction. It's not out of the question that this would
> break real-world use-cases --- imagine someone whose workflow involves
> copying data files across a network to a directory accessible to the
> server (and quite possibly specified by a relative path) and then doing
> COPY IN.
>
> In any case, this patch is missing documentation updates, specifically
> the paragraph in the COPY reference page that it falsifies.

Agreed. I'd like to withdraw the patch sent in the earlier post, and propose to
update the documentation in the COPY reference page. Please find attached a
patch.

Thanks,

Best regards,
Etsuro Fujita

Attachment Content-Type Size
copy_ref_page.patch application/octet-stream 990 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Farina 2012-08-16 07:02:07 Re: feature request: auto savepoint for interactive psql when in transaction.
Previous Message Gurjeet Singh 2012-08-16 05:36:40 Re: pg_prewarm