pg_resetxlog defect with relative database path

From: Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>
To: "'PostgreSQL-development'" <pgsql-hackers(at)postgresql(dot)org>
Subject: pg_resetxlog defect with relative database path
Date: 2012-11-22 13:22:27
Message-ID: 000f01cdc8b4$6c186920$44493b60$@kommi@huawei.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


When I was testing pg_resetxlog with relative database path,
The pg_resetxlog is doing the transaction log reset even when the server is
running.

Steps to reproduce:
1. ./pg_ctl -D ../../data start
2. ./pg_resetxlog -f ../../data -- is not able to detect as server
is already running.

Please find the patch for the same:

*** a/src/bin/pg_resetxlog/pg_resetxlog.c
--- b/src/bin/pg_resetxlog/pg_resetxlog.c
***************
*** 254,260 **** main(int argc, char *argv[])
*/
snprintf(path, MAXPGPATH, "%s/postmaster.pid", DataDir);

! if ((fd = open(path, O_RDONLY, 0)) < 0)
{
if (errno != ENOENT)
{
--- 254,260 ----
*/
snprintf(path, MAXPGPATH, "%s/postmaster.pid", DataDir);

! if ((fd = open("postmaster.pid", O_RDONLY, 0)) < 0)
{
if (errno != ENOENT)
{

Any suggestions/comments?

Regards,
Hari babu.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2012-11-22 14:56:52 Re: pg_resetxlog defect with relative database path
Previous Message Boszormenyi Zoltan 2012-11-22 13:05:56 Re: PQconninfo function for libpq