Re: new patch (was Re: Status check: Ibrar, Gianni, Matthew)

["Dave Page" <dpage(at)pgadmin(dot)org>]

Hi Gianni

On Thu, Nov 27, 2008 at 2:35 PM, Gianni Ciolli
<gianni(dot)ciolli(at)2ndquadrant(dot)it> wrote:
> On Wed, Nov 26, 2008 at 09:30:22AM +0000, Dave Page wrote:
>> Could you look at the posix_fadvise patch please?
>
> Hi Dave,
>
> if I'm correct, it looks like the posix_fadvise patch has been already
> reviewed some days ago, the reviewer made some suggestions, and the
> author is examining them.
>
> Perhaps you meant another patch? Or you are suggesting that there
> should be a multiple/collective review for that patch?

Multiple reviews. The existing review was largely a code style review,
but didn't cover any sort of perf testing etc. Plus it's always good
to get a second opinion :-)

The update to the patch should be posted today, but that is just a few
lines to remove a configure test I'm told. The server code will be
unchanged.


-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com