Re: solaris build problem with Sun compilers

[Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>]

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> Well, that's an interesting point ... I wonder what the version in
>> s_lock.c is used for at all?  Maybe it's dead code.

> I think the big question is what uses tas_dummy().  I only see it
> referenced in s_lock.c.

tas_dummy, per se, isn't used at all.  Notice it's declared static
so it couldn't possibly be referenced from anywhere else.  The actually
exported symbols are the labels declared in the assembly code.

And the thing that is striking is that while the other two tas_dummy asm
sections make a point of saying .global or equivalent, there isn't any
such declaration in this one.  Which is why I'm thinking it's dead
code.  Unless the sparc assembler has the unlikely convention that
symbols are global by default, there's no way to reference this.

Alan, could you try removing the __sparc code entirely from s_lock.c
and see if it still works on all those Solaris versions?

			regards, tom lane