Skip site navigation (1) Skip section navigation (2)

Peripheral Links

Header And Logo

PostgreSQL
| The world's most advanced open source database.

Site Navigation

Search archives
  Advanced Search

Re: [HACKERS] [DOCS] pg_total_relation_size() and CHECKPOINT


  • From: Magnus Hagander <magnus(at)hagander(dot)net>
  • To: "Zubkovsky, Sergey" <Sergey(dot)Zubkovsky(at)transas(dot)com>
  • Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org
  • Subject: Re: [HACKERS] [DOCS] pg_total_relation_size() and CHECKPOINT
  • Date: Tue, 29 Apr 2008 14:53:34 +0200
  • Message-id: <48171A4E.10707@hagander.net> <text/plain>

I already applied a different patch for this quite some time ago. So what's in HEAD (and current in 8.3 and 8.2) should be fixed already.

//Magnus

Zubkovsky, Sergey wrote:
Hi,

Here is the patch.
Check it, please.

Locations of the added files:
  src\include\port\win32_msvc\sys\stat.inl
  src\port\stat_pg_fixed.c


Thank you.


-----Original Message-----
From: Andrew Dunstan [mailto:andrew(at)dunslane(dot)net] Sent: Saturday, March 29, 2008 4:18 PM
To: Zubkovsky, Sergey
Cc: Tom Lane; Alvaro Herrera; Gregory Stark;
pgsql-hackers(at)postgresql(dot)org; Magnus Hagander
Subject: Re: [HACKERS] [DOCS] pg_total_relation_size() and CHECKPOINT




Zubkovsky, Sergey wrote:
In the prepared custom build of PG 8.3.1 the native MSVC's stat() was
rewrote by adding GetFileAttributesEx() to correct stat's st_size value.
I had seen that a result of MSVC's stat() and a result of
GetFileAttributesEx() may be differ by the file size values at least.
The most important thing is the test in the original post
( http://archives.postgresql.org/pgsql-docs/2008-03/msg00041.php )
doesn't reproduce any inconsistence now.
All work fine.

This was tested on my WinXP SP2 platform but I suppose it will work on
any NT-based OS.



If you have a patch, please send it to the -patches list.

cheers

andrew




Home | Main Index | Thread Index

Privacy Policy | About PostgreSQL
Copyright © 1996 – 2012 PostgreSQL Global Development Group