Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Header And Logo
|
Site Navigation
Re: Removing typename from A_Const (was: Empty arrays with ARRAY[])
- From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
- To: Brendan Jurd <direvus(at)gmail(dot)com>
- Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
- Subject: Re: Removing typename from A_Const (was: Empty arrays with ARRAY[])
- Date: Mon, 28 Apr 2008 12:27:02 -0400
- Message-id: <20080428162702(dot)GC5761(at)alvh(dot)no-ip(dot)org>
Brendan Jurd escribió: > Here's my attempt to remove the typename field from A_Const. There > were a few places (notably flatten_set_variable_args() in guc.c, and > typenameTypeMod() in parse_type.c) where the code expected to see an > A_Const with a typename, and I had to adjust for an A_Const within a > TypeCast. Nonetheless, there was an overall net reduction of 34 lines > of code, so I think this was a win. Do say ... why don't we do away with A_Const altogether and just replace it with Value? After this patch, I don't see what's the difference. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support
- Follow-Ups:
- References:
- Removing typename from A_Const (was: Empty arrays with ARRAY[])
- From: Brendan Jurd
- Removing typename from A_Const (was: Empty arrays with ARRAY[])
- Prev by Date: Re: generate_subscripts
- Next by Date: Re: Removing typename from A_Const (was: Empty arrays with ARRAY[])
- Previous by thread: Removing typename from A_Const (was: Empty arrays with ARRAY[])
- Next by thread: Re: Removing typename from A_Const (was: Empty arrays with ARRAY[])
- Indexes: