Re: Improve shutdown during online backup, take 4
- From: "Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at>
- To: "Tom Lane *EXTERN*" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
- Cc: "Magnus Hagander" <magnus(at)hagander(dot)net>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, <pgsql-patches(at)postgresql(dot)org>
- Subject: Re: Improve shutdown during online backup, take 4
- Date: Mon, 28 Apr 2008 08:57:51 +0200
- Message-id: <D960CB61B694CF459DCFB4B0128514C2020A7A83@exadv11.host.magwien.gv.at> <text/plain>
Tom Lane wrote:
> > I've attached a patch that works for me. I hope I got it right.
>
> Applied with additional cleanup. You hadn't thought very carefully
> about additional state transitions that would have to be introduced
> into the postmaster state machine to support a new state --- for
> example, as coded a SIGINT delivered to the postmaster after SIGTERM
> would fail to do anything at all, when of course it really ought to
> force us into fast shutdown. Also, it's not really that hard to
> disallow non-superusers from connecting in PM_WAIT_BACKUP state.
Thank you for helping.
You know, this is my first patch for server code. I know that I
still have a lot to learn until I grok how all that works
together.
Yours,
Laurenz Albe
- References:
- Improve shutdown during online backup, take 2
- Re: Improve shutdown during online backup, take 2
- Re: Improve shutdown during online backup, take 3
- Re: Improve shutdown during online backup, take 3
- Re: Improve shutdown during online backup, take 4
- Re: Improve shutdown during online backup, take 4
- Re: Improve shutdown during online backup, take 4
- Re: Improve shutdown during online backup, take 4
- Re: Improve shutdown during online backup, take 4
- Re: Improve shutdown during online backup, take 4
- Re: Improve shutdown during online backup, take 4
- Re: Improve shutdown during online backup, take 4
Home |
Main Index |
Thread Index