Skip site navigation (1) Skip section navigation (2)

Peripheral Links

Header And Logo

PostgreSQL
| The world's most advanced open source database.

Site Navigation

Search archives
  Advanced Search

Re: Improve shutdown during online backup

  • From: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
  • To: Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>
  • Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-patches(at)postgresql(dot)org
  • Subject: Re: Improve shutdown during online backup
  • Date: Mon, 07 Apr 2008 15:30:29 +0100
  • Message-id: <47FA3005.5070108@enterprisedb.com> <text/plain>
Albe Laurenz wrote:

Moreover, if Shutdown == SmartShutdown, new connections won't be accepted,
and nobody can connect and call pg_stop_backup().
So even if I'd add a check for
(pmState == PM_WAIT_BACKENDS) && !BackupInProgress() somewhere in the
ServerLoop(), it wouldn't do much good, because the only way for somebody
to cancel online backup mode would be to manually remove the file.


Good point.


So the only reasonable thing to do on smart shutdown during an online
backup is to have the shutdown request fail, right? The only alternative being
that a smart shutdown request should interrupt online backup mode.
Or we can add another state, PM_WAIT_BACKUP, before PM_WAIT_BACKENDS, that allows new connections, and waits until the backup ends. 

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com
Home | Main Index | Thread Index

Privacy Policy | PostgreSQL Archives hosted by Command Prompt, Inc. | Designed by tinysofa
Copyright © 1996 – 2008 PostgreSQL Global Development Group