Re: Bad bug in fopen() wrapper code
- From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
- To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>
- Cc: <pgsql-patches(at)postgresql(dot)org>
- Subject: Re: Bad bug in fopen() wrapper code
- Date: Sun, 24 Sep 2006 19:03:09 +0200
- Message-id: <6BCB9D8A16AC4241919521715F4D8BCEA0FBDF@algol.sollentuna.se> <text/plain>
> > Attached patch sets the O_CREAT option when appending to files.
>
> That looks correct, but I went looking to see if there were
> any other mistakes of the same ilk, and I'm wondering what
> the sense is in openFlagsToCreateFileFlags ... seems like
> it's ignoring O_EXCL in some combinations and not others. Is
> that right?
That is part of the original open() code that Claudio did back for 8.0,
so it has definitly been working since then. I haven't really read into
the code, though... But a qiuck look doesn't show me any place wher eit
does ignore O_EXCL - which combination would that be?
//Magnus
Home |
Main Index |
Thread Index