Re: [BUGS] BUG #2120: Crash when doing UTF8<->ISO_8859_8 encoding
- From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
- To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
- Cc: pgman(at)candle(dot)pha(dot)pa(dot)us, sagi(at)adamnet(dot)co(dot)il, pgsql-patches(at)postgresql(dot)org
- Subject: Re: [BUGS] BUG #2120: Crash when doing UTF8<->ISO_8859_8 encoding
- Date: Thu, 22 Dec 2005 23:38:26 -0500
- Message-id: <15856.1135312706@sss.pgh.pa.us> <text/plain>
Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> writes:
> I think the current implementaion in utf8_and_iso8859.c is fast but
> too fragile against rearranging of encoding id. I modify those functions
> in utf8_and_iso8859.c to do a linear search with encoding id.
That's not unreasonable, but I was wondering whether we could add some
Assert() tests that would catch problems without imposing any extra cost
in normal non-Assert builds.
regards, tom lane
Home |
Main Index |
Thread Index