Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Header And Logo
|
Site Navigation
Re: system() patch for Win32
- From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
- To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
- Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
- Subject: Re: system() patch for Win32
- Date: Thu, 03 Apr 2003 09:43:27 -0500
- Message-id: <28282(dot)1049381007(at)sss(dot)pgh(dot)pa(dot)us>
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes: > Here is a patch to handle 'rm', 'cp', and 'exec' usage by system(); > again very small. This part seems unnecessarily obscurantist: > ! #ifndef WIN32 > ! #define EXEC "exec " > ! #else > ! #define EXEC "" > ! #endif > ! sprintf(sys, "%s%s '%s'", EXEC, editorName, fname); I like the other style (just #ifdef to choose one of two sprintf commands) better. It seems easier to understand, as well as less fragile --- the way you have it here makes it *real* easy to break the computation of the buffer size for the command string. regards, tom lane
- Follow-Ups:
- Re: system() patch for Win32
- From: Bruce Momjian
- Re: system() patch for Win32
- References:
- system() patch for Win32
- From: Bruce Momjian
- system() patch for Win32
- Prev by Date: Win32 defines
- Next by Date: Re: Win32 defines
- Previous by thread: system() patch for Win32
- Next by thread: Re: system() patch for Win32
- Indexes: