From: | Joe Conway <mail(at)joeconway(dot)com> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Cc: | Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> |
Subject: | Table Function API patch (was Re: another SRF question) |
Date: | 2002-07-09 20:36:47 |
Message-ID: | 3D2B495F.6030802@joeconway.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Neil Conway wrote:
> On Mon, Jul 08, 2002 at 03:52:24PM -0700, Joe Conway wrote:
>>Nice catch. Here's (I think) a proper fix. This assumes that if
>>(values[i] != NULL), the datum is the output of the appropriate "in"
>>function, otherwise the datum is NULL. It saves the extra pass through
>>the dvalues array too.
>>
>>I thought you might want to try it out now without waiting for the patch
>>to get into cvs. I tested it with a contrived test function and it
>>worked as desired.
>
>
> Great, seems to work fine here. Thanks for fixing that for me.
>
Here is a patch for the Table Function API. It fixes a bug found by Neil
Conway (BuildTupleFromCStrings sets NULL for pass-by-value types when
intended value is 0). It also implements some other improvements
suggested by Neil.
If there are no objections, please apply.
Thanks,
Joe
Attachment | Content-Type | Size |
---|---|---|
tablefunc-fix.2002.07.09.1.patch | text/plain | 7.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Rod Taylor | 2002-07-10 01:43:40 | Between Node |
Previous Message | Neil Conway | 2002-07-09 20:16:01 | Re: UNIQUE predicate |