Race condition in org.postgresql.jdbc1.AbstractJdbc1Statement?

[jao(at)geophile(dot)com]

Cursor and statement names include the value of m_preparedCount:

    m_statementName = "JDBC_STATEMENT_" + m_preparedCount++;

and

    m_cursorName = "JDBC_CURS_" + m_preparedCount++;

m_preparedCount is static, and it looks like m_preparedCount++ should
be synchronized:

    // m_preparedCount is used for naming of auto-cursors and must
    // be synchronized so that multiple threads using the same
    // connection don't stomp over each others cursors.
    private static int m_preparedCount = 1;
    private synchronized static int next_preparedCount()
    {
        return m_preparedCount++;
    }

But next_preparedCount() is not used.

Should the creation of statement and cursor names use next_preparedCount()
instead of using m_preparedCount directly?

Jack Orenstein


----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.