VACUUM messages without newlines

From: Thom Brown <thombrown(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: VACUUM messages without newlines
Date: 2010-06-01 15:16:33
Message-ID: AANLkTik89BxK-DK84mljp06IUzxehw7fJIyP8bpmRwaL@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This has annoyed me for some time, but it appears that in the VACUUM
log, the line which says...

INFO: analyzing "%s.%s"

...( and appears in pgsql/src/backend/commands/analyze.c lines 282 and
287 ) doesn't terminate with a newline, meaning the next message
appears immediately after it. Either the errmsg function should be
doing this, or should be included explicitly in the message itself as
it does with all other messages output to VACUUM logs.

The same goes for...

CPU %d.%02ds/%d.%02du sec elapsed %d.%02d sec

... as appearing in pgsql/src/backend/utils/misc/pg_rusage.c (line 64)

and

"%s": scanned %d of %u pages, containing %.0f live rows and %.0f dead
rows; %d rows in sample, %.0f estimated total rows

... in pgsql/src/backend/commands/analyze.c (line 1220).

Could this be changed, or is there a reason these have to be logged this way?

Thanks

Thom

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2010-06-01 15:28:41 Re: VACUUM messages without newlines
Previous Message Kevin Grittner 2010-06-01 15:09:38 Re: dividing money by money