Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Header And Logo
|
Site Navigation
Re: some dead code in functioncmds.c
- From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
- To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
- Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
- Subject: Re: some dead code in functioncmds.c
- Date: Fri, 30 Oct 2009 17:17:24 +0100
- Message-id: <162867790910300917m321dbfd7udaa440b293be872@mail.gmail.com> <text/plain>
2009/10/30 Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>:
> Pavel Stehule wrote:
>> else
>> {
>> ereport(ERROR,
>> (errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),
>> errmsg("function result type must be specified")));
>> /* Alternative possibility: default to RETURNS VOID */
>>
>> /* WHY FOLOWING LINES? */
>> prorettype = VOIDOID;
>> returnsSet = false;
>> }
>
> To keep the compiler quiet about using the variables uninitialized. The
> compiler doesn't know that ereport(ERROR) never returns.
>
Should be similar code little bit commented?
Pavel
> --
> Heikki Linnakangas
> EnterpriseDB http://www.enterprisedb.com
>
- Follow-Ups:
- Re: some dead code in functioncmds.c
- From: Heikki Linnakangas
- Re: some dead code in functioncmds.c
- References:
- some dead code in functioncmds.c
- From: Pavel Stehule
- Re: some dead code in functioncmds.c
- From: Heikki Linnakangas
- some dead code in functioncmds.c
- Prev by Date: Patch set under development to add usage reporting.
- Next by Date: Re: Syntax for partitioning
- Previous by thread: Re: some dead code in functioncmds.c
- Next by thread: Re: some dead code in functioncmds.c
- Indexes: