Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Header And Logo
|
Site Navigation
Re: [PATCH] Cleanup of GUC units code
- From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
- To: Marko Kreen <markokr(at)gmail(dot)com>
- Cc: pgsql-hackers(at)postgresql(dot)org
- Subject: Re: [PATCH] Cleanup of GUC units code
- Date: Sun, 31 Aug 2008 22:56:35 -0400
- Message-id: <2879.1220237795@sss.pgh.pa.us> <text/plain>
Marko Kreen <markokr(at)gmail(dot)com> writes: > - In attempt to preserve maximum range of values for INT64_IS_BUSTED > systems, the code is written rather non-obvious way. I do not personally object a bit to making the units comparisons case-insensitive (I think it's mainly Peter who wants to be strict about it). I don't think there are any other good ideas in this patch, however, and exposing ourselves to intermediate overflows in the name of simplicity is definitely not one. regards, tom lane
- References:
- [PATCH] Cleanup of GUC units code
- From: Marko Kreen
- [PATCH] Cleanup of GUC units code
- Prev by Date: Re: [PATCH] Make gram.y use palloc/pfree for memory management
- Previous by thread: [PATCH] Cleanup of GUC units code
- Next by thread: [PATCH] In case module has wrong magic, report exact problem
- Indexes: