Re: [PATCHES] GIN improvements

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] GIN improvements
Date: 2008-07-24 19:24:11
Message-ID: 4888D6DB.8030100@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> queries return the same row twice. A bitmap indexscan plan would mask
> such an index bug ... but a plain indexscan won't.

Fuh. :(. Well. Will fix.

GiST:
- GiST already supports both scan directions in theory, but page split may
change order between forward and backward scans (user-defined pageSplit doesn't
preserve order of tuples). Holding of split until end of scan will produce
unacceptable concurrency level.
- GiST can return one itempointer twice. It's fixable by storing content of
current page in memory instead of just keeping page pinned. Will do (backpatches
too).

GIN:
- GIN doesn't support backward scan direction and will not support in close
future.
- Right now GIN doesn't return twice the same itempointer, but with current
fast_insert patch it might return. So, suppose, to fix that it's enough just to
remember itempointers returned from pending list and use it as filter for
results from regular structure. Will do.
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2008-07-24 19:31:52 Re: Do we really want to migrate plproxy and citext into PG core distribution?
Previous Message Tom Lane 2008-07-24 19:19:16 Re: [PATCHES] WITH RECUSIVE patches 0723

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-07-24 20:30:09 Re: [PATCHES] GIN improvements
Previous Message Tom Lane 2008-07-24 19:19:16 Re: [PATCHES] WITH RECUSIVE patches 0723