From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Gregory Stark <stark(at)enterprisedb(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
Subject: | Re: Kludge in pg_standby.c |
Date: | 2008-04-10 17:48:09 |
Message-ID: | 20080410174809.GA15380@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Gregory Stark wrote:
> >
> > There's a suspicious ifdef in pg_standby for WIN32 which smells like a kludge
> > added to work around a Windows problem which makes it work but at great
> > expense:
> >
> > #ifdef WIN32
> > /*
> > * Windows reports that the file has the right number of bytes
> > * even though the file is still being copied and cannot be
> > * opened by pg_standby yet. So we wait for sleeptime secs
> > * before attempting to restore. If that is not enough, we
> > * will rely on the retry/holdoff mechanism.
> > */
> > pg_usleep(sleeptime * 1000000L);
> > #endif
FWIW, it seems that this may be fixed with Magnus' patch to change
stat() on Win32. Is there anyone with a working warm standby PITR setup
on Win32 that could test it?
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-04-10 17:48:14 | Re: Index AM change proposals, redux |
Previous Message | Fabiana Prabhakar | 2008-04-10 17:47:38 |