Re: Datum should be defined outside postgres.h

[Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>]

Tom Lane wrote:
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> > My idea is to put functions declaration int pg_xxx.h and structure
> > declaration in pg_xxx_def.h. I'm not sure if split DATA into separate
> > header is good idea, but if yes then pg_xxx_data.h should be good name
> > for it (it seems that pg_dump needs only defines).
>
> That seems far more invasive than is justified, as it will essentially
> force touching every file that includes any catalog header.  

Not exactly pg_type could include pg_type.data, but you are right it is 
more invasive than I really need.

> I think
> the vast majority are including for the struct definitions, and so the
> structs should stay where they are.  

Ok. In this point of view better should be create e.g. pg_type_fn.h with 
function declaration and add this include file into related files.


		Zdenek