Re: Configurable Additional Stats

[Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>]

Dave Page <dpage(at)postgresql(dot)org> writes:
> Tom Lane wrote:
>> Mph --- the proposal was very poorly titled then.  In any case, it still
>> sounds like a one-off hack that would be equally well served by a local
>> patch.

> It's certainly not intended as a one-off hack, but as a way of analysing
> the behaviour of existing and new applications. It would certainly be
> useful for us in the future, and most likely others as well once a
> plugin or two has been released.

I'd be more interested if I saw a believable spec for a plugin using
this.  So far it sounds terribly badly designed --- for starters,
apparently it's intending to ignore the stats aggregation/reporting
infrastructure and reinvent that wheel in some unspecified way, for
unspecified reasons.  If you think you can improve on that mechanism
(which I'm prepared to believe, though I'd like to see some details)
why wouldn't the proposed hook include a way to turn off the overhead
of the regular stats collector?  If that's not the point, then what
is the point?

			regards, tom lane