Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Header And Logo
|
Site Navigation
Re: SetBufferCommitInfoNeedsSave and race conditions
- From: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
- To: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
- Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>, "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
- Subject: Re: SetBufferCommitInfoNeedsSave and race conditions
- Date: Thu, 28 Jun 2007 23:17:06 +0100
On Thu, 2007-06-28 at 15:29 -0400, Alvaro Herrera wrote: > Tom Lane escribió: > > Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes: > > > AFAICS, we can just simply remove the assertion. But is there any > > > codepaths that assume that after calling HeapTupleSatisfiesSnapshot, all > > > appropriate hint bits are set? > > > > There had better not be, since we are going to postpone setting hint > > bits for recently-committed transactions as part of the async-commit > > patch. > > > > A quick grep suggests that VACUUM FULL might be at risk here. > > That particular case seems easily fixed since VACUUM FULL must hold an > exclusive lock; and we can forcibly set sync commit for VACUUM FULL. Exactly what it does! -- Simon Riggs EnterpriseDB http://www.enterprisedb.com
- References:
- SetBufferCommitInfoNeedsSave and race conditions
- From: Pavan Deolasee
- Re: SetBufferCommitInfoNeedsSave and race conditions
- From: Heikki Linnakangas
- Re: SetBufferCommitInfoNeedsSave and race conditions
- From: Tom Lane
- Re: SetBufferCommitInfoNeedsSave and race conditions
- From: Alvaro Herrera
- SetBufferCommitInfoNeedsSave and race conditions
- Prev by Date: Re: lazy vacuum sleeps with exclusive lock on table
- Next by Date: Re: lazy vacuum sleeps with exclusive lock on table
- Previous by thread: Re: SetBufferCommitInfoNeedsSave and race conditions
- Next by thread: Re: SetBufferCommitInfoNeedsSave and race conditions
- Indexes: