Re: Query plan degradation 8.2 --> 8.3

[Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>]

Josh Berkus <josh(at)agliodbs(dot)com> writes:
>> It does the right thing if t_s_symb is declared as text instead of
>> varchar.  When it's varchar, even setting enable_sort off won't make
>> it pick the right plan, which suggests that it fails to recognize that
>> the index can match the query's ORDER BY.  I'm guessing I overlooked
>> a binary-compatibility case when I rejiggered the handling of PathKeys
>> in connection with the NULLS FIRST/LAST stuff.  No time to look deeper
>> right now.

> Yeah, that looks like the case.  We'll move it to TEXT for the tests right 
> now, but I'll make sure we don't forget this bug during beta.  Thanks!

I've applied a patch that fixes this case, but I'm not yet 100%
convinced that there are no other cases where it'll prevent matching
things that should match.  Please test.

			regards, tom lane