Re: [HACKERS] \copy (query) delimiter syntax error

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Fuhr <mike(at)fuhr(dot)org>, pgsql-hackers(at)postgresql(dot)org, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] \copy (query) delimiter syntax error
Date: 2007-02-20 02:50:07
Message-ID: 45DA61DF.3080607@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


I think I'll go with Tom's Plan B for HEAD, but not do anything more for
8.2 than has already been done.

cheers

andrew

Bruce Momjian wrote:
> Did we come to a conclusion on this?
>
> ---------------------------------------------------------------------------
>
> Andrew Dunstan wrote:
>
>> Andrew Dunstan wrote:
>>
>>> Tom Lane wrote:
>>>
>>>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>>>
>>>>
>>>>> The consequence will be, though, that psql will accept a syntax for
>>>>> "\copy (query) ..." that the corresponding backend command would
>>>>> reject were we not transforming it. That strikes me as potentially
>>>>> confusing.
>>>>>
>>>>>
>>>> Perhaps. What about plan B: remove the legacy syntax support in \copy?
>>>> IIRC it has not been documented since 7.2, so maybe we can finally throw
>>>> it overboard. Thoughts?
>>>>
>>>>
>>>>
>>>>
>>> I like it for 8.3 - but maybe my present patch would be better for
>>> 8.2, as it involves less behaviour change.
>>>
>>>
>> While we decide this issue, which can be worked around in any case, I am
>> going to commit the part of the patch that nobody has objected to (and
>> which will fix Michael's original complaint), on HEAD and 8.2 stable, so
>> we can get some testing going.
>>
>> cheers
>>
>> andrew
>>
>> ---------------------------(end of broadcast)---------------------------
>> TIP 4: Have you searched our list archives?
>>
>> http://archives.postgresql.org
>>
>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2007-02-20 03:10:52 Re: Multiple Storage per Tablespace, or Volumes
Previous Message Galy Lee 2007-02-20 02:35:59 Re: autovacuum next steps

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-02-20 03:25:21 WIP: replacing executor's use of Query with a PlannedStmt node type
Previous Message Bruce Momjian 2007-02-20 02:31:27 Re: [pgsql-patches] Patch to avoid gprofprofilingoverwrites