Let psql process files with > 4,294,967,295 lines

From: David Fetter <david(at)fetter(dot)org>
To: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Let psql process files with > 4,294,967,295 lines
Date: 2006-07-30 21:23:23
Message-ID: 20060730212323.GU2654@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Folks,

I just ran across an issue where in psql, people can get the line
number in the file so long as it is under 2^32-1 lines long, but once
it gets larger than that, it's hosed.

This patch changes the data type from unsigned int to unsigned long
long, which is probably not the correct thing in order to get 64-bit
arithmetic, but I figure it's good enough to get a discussion started.

Cheers,
D
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter

Remember to vote!

Attachment Content-Type Size
psql_long_file.diff text/plain 2.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2006-07-30 21:30:40 Re: Let psql process files with > 4,294,967,295 lines
Previous Message Tom Lane 2006-07-30 21:19:04 Re: Relation locking and relcache load (was Re: Going for "all green" buildfarm results)