Re: error in compilation!
- From: "Gurjeet Singh" <singh(dot)gurjeet(at)gmail(dot)com>
- To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
- Cc: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PGSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>
- Subject: Re: error in compilation!
- Date: Sun, 28 May 2006 01:05:08 +0530
- Message-id: <65937bea0605271235i4ae5e3cau1dcb8697da68acde(at)mail(dot)gmail(dot)com>
Any ideas how I can revert back to compilable code?
On 5/28/06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I am thinking it is best to always use E'' in that case. OK?
I'm planning to revert it to the previous logic: E if there's any
backslash. I think we have to do likewise in quote_literal() for
much the same reason: insufficient confidence that we know how
the result will be used. (Note dblink uses quote_literal for
strings it will send to the other database.)
Currently looking through the rest of the patch. I'm wondering
about appendStringLiteral: maybe we should kill that entirely
in favor of using PQescapeStringConn? It's not nearly bright
enough about encoding for instance (and it *will* be used in
client-only encodings).
regards, tom lane
Home |
Main Index |
Thread Index