Re: Strange interval arithmetic

[Alvaro Herrera <alvherre(at)commandprompt(dot)com>]

Michael Fuhr wrote:

> Agreed.  I'm thinking about rewriting strtol() calls in datetime.c
> to look like this:
> 
>   errno = 0;
>   val = strtol(field[i], &cp, 10);
>   if (errno == ERANGE)
>       return DTERR_FIELD_OVERFLOW;

Hmm, why not check both the return value _and_ errno:

val = strtol(field[i], &cp, 10);
if (val == LONG_MAX && errno == ERANGE)
	return DTERR_FIELD_OVERFLOW;

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support