Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Header And Logo
|
Site Navigation
Re: Strange interval arithmetic
- From: Michael Fuhr <mike(at)fuhr(dot)org>
- To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
- Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
- Subject: Re: Strange interval arithmetic
- Date: Wed, 30 Nov 2005 11:28:07 -0700
- Message-id: <20051130182806(dot)GA98044(at)winnie(dot)fuhr(dot)org>
On Wed, Nov 30, 2005 at 12:37:40PM -0500, Tom Lane wrote: > Michael Fuhr <mike(at)fuhr(dot)org> writes: > >> I see this behavior back to at least 7.3. I'd guess it's because > >> strtol() indicates overflow by returning LONG_MAX and setting errno > >> to ERANGE, but the code doesn't check for that. > > > Is this worth looking at for the upcoming dot releases? > > Sure, send a patch ... Any preferences on an approach? The simplest and easiest to verify would be to raise an error for just this particular case; a TODO item might be to change how the string is parsed to allow values larger than LONG_MAX. I see several calls to strtol() that aren't checked for overflow but that might not be relevant to this problem, so I'm thinking this patch ought not touch them. Maybe that's another TODO item. -- Michael Fuhr
- Follow-Ups:
- Re: Strange interval arithmetic
- From: Tom Lane
- Re: Strange interval arithmetic
- References:
- Strange interval arithmetic
- From: Christopher Kings-Lynne
- Re: Strange interval arithmetic
- From: Michael Fuhr
- Re: Strange interval arithmetic
- From: Michael Fuhr
- Re: Strange interval arithmetic
- From: Michael Fuhr
- Re: Strange interval arithmetic
- From: Tom Lane
- Strange interval arithmetic
- Prev by Date: Re: Upcoming PG re-releases
- Next by Date: Re: [pgsql-www] Upcoming PG re-releases
- Previous by thread: Re: Strange interval arithmetic
- Next by thread: Re: Strange interval arithmetic
- Indexes: